Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more support target #98

Closed
wants to merge 1 commit into from
Closed

Conversation

sndnvaps
Copy link

No description provided.

@sndnvaps sndnvaps requested a review from a team as a code owner October 15, 2024 13:42
@sndnvaps
Copy link
Author

add targets to .cargo/config.toml

targets = [
    "thumbv7em-none-eabi",
    "thumbv7m-none-eabi",
    "thumbv6m-none-eabi",
    "thumbv7em-none-eabihf",
    "thumbv8m.main-none-eabihf",
]

@Dirbaio
Copy link
Member

Dirbaio commented Oct 15, 2024

What is the motivation for this change? Note the crate already supports all targets, you don't need to list a target as "supported" in .cargo/config.toml.

the syntax is incorrect, please check the docs https://doc.rust-lang.org/cargo/reference/config.html

@sndnvaps
Copy link
Author

sndnvaps commented Oct 15, 2024

when i build in support
Raspberry pi Pico2 ( RP2350) ->
target: thumbv8m.main-none-eabihf
it can't build , get error.
so i add the target list to make it work

@jannic
Copy link
Member

jannic commented Oct 15, 2024

That should already work, without any change.
Actually, embedded-alloc is used in one of the examples of rp235x-hal, and that's covered by a CI test:
https://github.com/rp-rs/rp-hal/blob/main/rp235x-hal-examples/src/bin/alloc.rs
https://github.com/rp-rs/rp-hal/actions/runs/11104091070/job/30847447078

@Dirbaio
Copy link
Member

Dirbaio commented Oct 15, 2024

as I said, please check docs. https://doc.rust-lang.org/cargo/reference/config.html

The "targets" field doesn't exist.

@sndnvaps sndnvaps closed this Oct 17, 2024
@sndnvaps
Copy link
Author

i have clean the project to test it . just fine, thank bro, to answer my question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants