Specialize Intersperse::fold

[jswrenn]

Overriding Intersperse::fold's default implementation makes iteration with for_each approximately 10× faster than external iteration, and approximately 20× faster than for_each with an un-specialized fold:

$ cargo bench -- specialization
specialization::intersperse::internal_specialized          64 ns/iter (+/- 1)
specialization::intersperse::external                     638 ns/iter (+/- 45)
specialization::intersperse::internal_unspecialized     1,274 ns/iter (+/- 131)

[jswrenn]

@bluss I'd be interested in helping maintain itertools if you're still looking for someone. I'm a member of the rustsim organization, a regular contributor to nalgebra, and a drive-by contributor of API improvements to many libraries.

[bluss]

bors: r+

Thanks!

[bluss]

Yes, maintenance is definitely needed here, it would be great to have you if you are willing to take ownership!

[bors]

Build succeeded

• continuous-integration/travis-ci/push

[jswrenn]

Yes, maintenance is definitely needed here, it would be great to have you if you are willing to take ownership!

I am!

[bluss]

Great, you're added as a contributor. crates.io invite sent. Nothing more is technically needed, but we could move this repo to an organization?

Thank you! I was supposed to give some maintenance advice too. Remember that a maintainer needs to make decisions and should make decisions, so don't feel bad for doing exactly that.

[jswrenn]

Thanks, @bluss! Life is unusually busy for me at the moment (all good things!), but I think I can generally give itertools at least a few hours each week, and I'll aim for (at the very least) monthly minor releases.

I'm thrilled to have the opportunity to give back to this library. I've used itertools in nearly every data analysis pipeline I've built so far in my PhD.

I've sent you an invitation to the rust-itertools organization. At your convenience, could you transfer this repository to that organization? To avoid breaking any cargo git dependencies, it's probably a good idea if you then create a fork of itertools under your account.

[bluss]

Interesting conundrum since afaik if I create a fork, it breaks a lot of the redirects that github sets up. Will transfer after having done some research on that

[jswrenn]

Ah, I wasn't aware github creates redirects. If so, no need to create a fork!

[bluss]

New home done. 🎉 I've renamed the repo to just itertools since I think that's what we would use inside this organisation. All the automatic redirects should mean it all works.

The old github pages site was just full of redirects to docs.rs. I removed github pages in the new location, because right now it dosen't seem useful to establish a new url for a lot of redirects. The redirects are kept at http://bluss.github.io/rust-itertools/ (by moving the github pages content from blus/rust-itertools to blus/bluss.github.io.

[bluss]

Also, thrilled that you are coming on! If you feel like it, we can see if others want to join the team. I haven't had much time for Rust, and uncertain about the future. Near future is vacation and not Rust at least :)

[jswrenn]

I'll be able to start giving itertools attention this thursday, and also next week. :)

Enjoy your vacation!