Skip to content

Commit

Permalink
Unrolled build for rust-lang#116326
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#116326 - Colonial-Dev:issue-116165-fix, r=joshtriplett

Correct misleading std::fmt::Binary example (rust-lang#116165)

Nothing too crazy...

- Add two to the width specifier (so all 32 bits are correctly displayed)
- Pad out the compared string so the assert passes
- Add `// Note` comment highlighting the need for the extra width when using the `#` flag.

The exact contents (and placement?) of the note are, of course, highly bikesheddable.
  • Loading branch information
rust-timer authored Oct 2, 2023
2 parents b0889cb + f2ecf7c commit 59b6263
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions library/core/src/fmt/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -791,8 +791,10 @@ pub trait Octal {
/// assert_eq!(format!("l as binary is: {l:b}"), "l as binary is: 1101011");
///
/// assert_eq!(
/// format!("l as binary is: {l:#032b}"),
/// "l as binary is: 0b000000000000000000000001101011"
/// // Note that the `0b` prefix added by `#` is included in the total width, so we
/// // need to add two to correctly display all 32 bits.
/// format!("l as binary is: {l:#034b}"),
/// "l as binary is: 0b00000000000000000000000001101011"
/// );
/// ```
#[stable(feature = "rust1", since = "1.0.0")]
Expand Down

0 comments on commit 59b6263

Please sign in to comment.