Don't look for old RUSTC_DEBUGINFO vars #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton Would you mind bumping the version of backtrace-sys? I can't release the crate but I'm happy to do the upgrade in rustc. |
|
Sure thing, done now! |
|
@alexcrichton sorry, but I don't see a new version bump anywhere? |
|
Er sorry forgot to push the commit, but 0.1.37 of backtrace-sys should be on crates.io. Also just pushed the commit. |
|
ah okay I forgot to check crates.io. Thanks!! |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Apr 30, 2020
Diff: - Don't look for old RUSTC_DEBUGINFO vars (rust-lang/backtrace-rs#313)
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Apr 30, 2020
…k-Simulacrum Update backtrace-sys Diff: - Don't look for old RUSTC_DEBUGINFO vars (rust-lang/backtrace-rs#313) This fixes an issue of libbacktrace never being built with debuginfo. r? @Mark-Simulacrum cc @alexcrichton
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jun 12, 2020
Diff: - Don't look for old RUSTC_DEBUGINFO vars (rust-lang/backtrace-rs#313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing libbacktrace to be built without debuginfo when I had debuginfo enabled in the rust build.
As far as I can tell, these aren't used anymore; they don't appear in rust-lang/rust. The only var that remains in bootstrap is
RUSTC_DEBUGINFO_MAP.Instead, using the
DEBUGenvironment variable like normal crates do appears to be correct, so no special handling is needed anymore. I verified this works on a local rustc build.