Add support for Github API for querying repository info #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simplify code elsewhere.
…l git checkout implementation.
You turn it on via `--access=github`.
Note A local git checkout is still the default value for `--access`; I
do not want to make github access the default until we make the experience
a bit more user-friendly. Most notable are the following to-do's:
1. To-do: Fallback to local checkout if the github accessor errors out
2. To-do: Add a warning to stdout if the user runs github access without
passing an access token via GITHUB_TOKEN env var (since doing that will
hit rate limit much faster).
|
Great work @pnkfelix this looks very good. Will wait for you to address @chrissimpkins comments and then I'd merge it :). |
|
@spastorino okay I think everything has been resolved now. (I am separately working on a regression test infrastructure; that side-project has given me sufficient confidence that this does seem to be working. I'll be posting the test system in a separate PR later; its taking me longer to polish than I expected.) |
Actually, I'm going to interpret this as an implicit "r=me" from @spastorino and go ahead and merge this myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--accesscommand line flag.There are two values current for the flag:
--access=checkout(the original behavior, and remains the default for now) and `--access=github (the new behavior).In the long term, we will probably want
--access=githubto be the default, but there are some refinements I think we want before we do that.In any case, I wanted to get this code up so that it doesn't bitrot further, since it seems like there are parallel efforts that could accelerate bitrot if I don't get it up.
The aforementioned refinements are written out in one of the commits, but here they are again:
To-do: Fallback to local checkout if the github accessor errors out
To-do: Add a warning to stdout if the user runs github access without passing an access token via GITHUB_TOKEN env var (since doing that will hit rate limit much faster).
Fix #40