-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #13993 - epage:path-source, r=ehuss
refactor(source): Split `RecursivePathSource` out of `PathSource` ### What does this PR try to resolve? `PathSource` serves a couple of roles - When a dependency / patch uses `path` (non-recursive) - As the implementation details of a `git` source (recursive) - Dependency overrides (recursive) Instead of using a `PathSource::new` vs `PathSouce::new_recursive`, this does `RecursivePathSource::new`. This makes the intent a lot clearer and makes it easier to customize the behavior to each role that is played. Specifically, there are two ways I expect to leverage this refactor - Improve the interplay between `RecursivePathSource` and `read_packages` to reduce the duplicate package warnings for git sources (#13992) - cargo script will change the semantics of path sources slightly and I'm assuming having a distinct source will make this easier ### How should we test and review this PR? ### Additional information
- Loading branch information
Showing
5 changed files
with
771 additions
and
600 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.