Some tiny refactors around ops::cargo_compile
#11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @epage (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
epage
reviewed
Oct 17, 2022
| /// Generally, it represents the combination of all `-p` flag. When working within | ||
| /// a workspace, `--exclude` and `--workspace` flags also contribute to it. | ||
| #[derive(PartialEq, Eq, Debug)] | ||
| pub enum Packages { |
There was a problem hiding this comment.
Side note: long term, I wonder where this should belong as this seems like a more fundamental CLI package selection struct that is useful outside of compilation.
For example, clap-cargo tries to imitate this for general use. cargo-release is at least one program that uses that logic. cargo-upgrade had another implementation of it until we switched to oly operating on the workspace.
Being buried in cargo_compile makes this less discoverable.
There was a problem hiding this comment.
Fully agree. That's why even I hate the lost of git history so much but still did this 🫠
weihanglo
force-pushed
the
refactor/cargo_compile
branch
from
286c5ec to
886c9d2
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Oct 17, 2022
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Oct 18, 2022
6 commits in b332991a57c9d055f1864de1eed93e2178d49440..3ff044334f0567ce1481c78603aeee7211b91623 2022-10-13 22:05:28 +0000 to 2022-10-17 20:25:00 +0000 - Some tiny refactors around `ops::cargo_compile` (rust-lang/cargo#11243) - Polish docs for module `build_context` (rust-lang/cargo#11241) - Remove sparse+ prefix for index.crates.io (rust-lang/cargo#11247) - docs(add): Add missing flags to reference (rust-lang/cargo#11240) - Document `cargo remove` (rust-lang/cargo#11227) - fix: Update help headings to match clap (rust-lang/cargo#11239)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 19, 2022
Update cargo 6 commits in b332991a57c9d055f1864de1eed93e2178d49440..3ff044334f0567ce1481c78603aeee7211b91623 2022-10-13 22:05:28 +0000 to 2022-10-17 20:25:00 +0000 - Some tiny refactors around `ops::cargo_compile` (rust-lang/cargo#11243) - Polish docs for module `build_context` (rust-lang/cargo#11241) - Remove sparse+ prefix for index.crates.io (rust-lang/cargo#11247) - docs(add): Add missing flags to reference (rust-lang/cargo#11240) - Document `cargo remove` (rust-lang/cargo#11227) - fix: Update help headings to match clap (rust-lang/cargo#11239)
bors
added a commit
that referenced
this pull request
Feb 3, 2023
refactor: mod.rs over "name".rs for consistency See #11243 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Some tiny refactors I found during polishing documentations.
CompileFilterandPackagesfromops::cargo_compileto their own modules.FilterRule::try_collectas its intent is not clear, and we don't need this indirection.CompileOptions::local_rustdoc_args, which is obsolete since 1ef954e.How should we test and review this PR?
This shouldn't include any functional change.
Better to review it commit by commit.
Additional information
Moving code back and forth is indeed bad for git history tracking, but it seems better for me to make boundaries on types with different purposes. The lines of code of
cargo_compile.rsis also reduced from 1977 to 1460, which is nicer to read.