[beta-1.70] backport add the Win32_System_Console feature #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the Win32_System_Console feature since it is used In `src/cargo/core/shell.rs` `windows_sys::Win32::System::Console` is used but the feature is not present in Cargo.toml. I found it while updating `cargo-c`.
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
the
S-waiting-on-review
Fix semver checks for 1.69 There is a small wording change in the 1.69 release that was causing this test to fail.
weihanglo
approved these changes
Apr 25, 2023
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2023
…nglo [beta] Update cargo 2 commits in 84b7041fd2745ee6b3b4a150314f81aabb78e6b2..ec8a8a0cabb0e0cadef58902470f6c7ee7868bdc 2023-04-13 20:08:40 +0000 to 2023-04-25 19:46:25 +0000 - [beta-1.70] backport add the Win32_System_Console feature (rust-lang/cargo#12038) - [beta-1.70] Backport not_found_permutations test fix. (rust-lang/cargo#11983) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beta backport of #12016 which is required to build the cargo library on Windows.
This also includes #12011 to get CI passing.