Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ref): Highlight commands to answer dep resolution questions #12903

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 31, 2023

Previously, in the #6666, the aptly named cargo lucifer was suggested for answering resolver questions.

Turns out most of these can be answered now, between logging and cargo tree.
This adds troubleshooting tips to help highlight the use of these commands to answer these questions.

Fixes #6666

Previously, in the rust-lang#6666, the aptly named `cargo lucifer` was suggested
for answering resolver questions.

Turns out most of these can be answered now, between logging and `cargo
tree`.
This adds troubleshooting tips to help highlight the use of
these commands to answer these questions.

Fixes rust-lang#6666
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we might want to put all troubleshootings in one place. Maybe under FAQ? It has aleady got some lengthy contents like Why is Cargo rebuilding my code? and What does “version conflict” mean and how to resolve it?

That said, I do feel this PR fits in the natural reading style.

@@ -517,6 +551,17 @@ But, if you run into this situation, the [`cargo update`] command with the

[`cargo update`]: ../commands/cargo-update.md

### Why wasn't a newer version selected?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can link to an issue having some guidance for debugging as an example. I can't recall any specific one at this moment but I believe there are some.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have one, that'd be great. I can't think of ay.

@epage epage mentioned this pull request Oct 31, 2023
@weihanglo
Copy link
Member

Go ahead and merge this!
@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2023

📌 Commit 086d16c has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Testing commit 086d16c with merge 4fbc6a9...

@bors
Copy link
Contributor

bors commented Oct 31, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4fbc6a9 to master...

@bors bors merged commit 4fbc6a9 into rust-lang:master Oct 31, 2023
19 checks passed
@epage epage deleted the docs-deps branch October 31, 2023 20:29
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2023
Update cargo

8 commits in b4d18d4bd3db6d872892f6c87c51a02999b80802..65e297d1ec0dee1a74800efe600b8dc163bcf5db
2023-10-31 18:19:10 +0000 to 2023-11-03 20:56:31 +0000
- fix(cli): Clarify --test is for targets, not test functions (rust-lang/cargo#12915)
- Updating "features" documentation to add a note about the new limit on number of features (rust-lang/cargo#12913)
- fix: merge `trim-paths` from different profiles (rust-lang/cargo#12908)
- Add regression test for issue 6915: features and transitive dev deps (rust-lang/cargo#12907)
- chore(deps): update rust crate gix to 0.55.2 (rust-lang/cargo#12906)
- chore(deps): update compatible (rust-lang/cargo#12905)
- docs(ref): Fix open-semver-range issue link (rust-lang/cargo#12904)
- docs(ref): Highlight commands to answer dep resolution questions (rust-lang/cargo#12903)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cargo lucifer subcommand
5 participants