feat(toml): Allow adding/removing from cargo scripts #14857
Merged
+742
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-cli
34 tasks
epage
force-pushed
the
script-mut
branch
4 times, most recently
from
2a5fdea
to
6fa341d
Compare
ehuss
reviewed
Nov 26, 2024
Comment on lines
+213
to
+217
| // Ok, this is a shebang but if the next non-whitespace token is `[`, | ||
| // then it may be valid Rust code, so consider it Rust code. | ||
| if rest.trim_start().starts_with('[') { | ||
| return Ok(source); | ||
| } |
There was a problem hiding this comment.
Just a comment: This isn't quite the same behavior, as the compiler allows comments before the opening [. I realize parsing that would be difficult, and that particular scenario is a bit silly.
There was a problem hiding this comment.
This is existing code, just moved. Ok if we put this in the tracking issue or an issue and track separately?
Comment on lines
+303
to
+308
| if !manifest.ends_with("\n") { | ||
| manifest.push_str("\n"); | ||
| } | ||
| let fence = "---\n"; |
There was a problem hiding this comment.
Just a comment: These look like it will cause mixed line endings on a CRLF file. However, that looks like it is an existing problem with cargo add in general.
There was a problem hiding this comment.
As this is another manifestation of an existing issue, are we ok with deferring this out of this PR?
This will make it easier to add cargo script support
epage
force-pushed
the
script-mut
branch
3 times, most recently
from
a6a3dfe
to
26844a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This adds support for cargo script for more cargo commands and is a part of #12207
Unfortunately, there is a double-warning for unspecified editions for
cargo remove. Rather than addressing that here, I'll be noting it in the tracking issue.How should we test and review this PR?
Additional information