[beta] Hash Kind in metadata for crates
#4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes what is now a bug in Cargo discovered when attempting to land rust-lang/rust#42495 where Cargo will compile both host and target artifacts with the same `-C metadata` flag. This means that the compile can load two crates with the same SVH that are supposed to be distinct, which causes weird bugs with crate loading and whatnot. This commit throws in the `Kind` into the metadata calculation to resolve this to ensure that host/target artifacts always have a different `-C metadata`
|
@bors: r+ |
|
📌 Commit 7177f56 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
⌛ Testing commit 7177f56 with merge 56f4979... |
|
💔 Test failed - status-appveyor |
|
Seems spurious, but I don't think I can retry -- might as well try, I guess. @bors retry |
|
@bors: retry This'll require #4171 to go in first but that should likely land. @Mark-Simulacrum want to add yourself to Cargo reviewers? |
bors
added a commit
that referenced
this pull request
Jun 14, 2017
[beta] Hash `Kind` in metadata for crates This fixes what is now a bug in Cargo discovered when attempting to land rust-lang/rust#42495 where Cargo will compile both host and target artifacts with the same `-C metadata` flag. This means that the compile can load two crates with the same SVH that are supposed to be distinct, which causes weird bugs with crate loading and whatnot. This commit throws in the `Kind` into the metadata calculation to resolve this to ensure that host/target artifacts always have a different `-C metadata`
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added a commit
to brson/rust
that referenced
this pull request
Jun 15, 2017
Pulls in two beta fixes for cargo: * rust-lang/cargo#4169 * rust-lang/cargo#4170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what is now a bug in Cargo discovered when attempting to land
rust-lang/rust#42495 where Cargo will compile both host and target artifacts
with the same
-C metadataflag. This means that the compile can load twocrates with the same SVH that are supposed to be distinct, which causes weird
bugs with crate loading and whatnot.
This commit throws in the
Kindinto the metadata calculation to resolve thisto ensure that host/target artifacts always have a different
-C metadata