Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cargo search --host with cargo search --index #4267

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

natboehm
Copy link
Contributor

This change makes the command consistent with other versions of the same flag. cargo search --host is still supported, as well as cargo search --index <index> --host <host> in case of confusion. The three commands currently supported should produce the same behavior. All instances of --host are currently marked as deprecated, or for reuse as mentioned in issue #4208.

Fixes #4219

natboehm added 2 commits July 10, 2017 11:19
…pport using '--host' with warning message, added test to support using both '--host' and '--index' with warning message for host
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Member

matklad commented Jul 10, 2017

LGTM, thanks @natboehm !

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2017

📌 Commit 4d30d52 has been approved by matklad

@bors
Copy link
Contributor

bors commented Jul 10, 2017

⌛ Testing commit 4d30d52 with merge 2b8de5d...

bors added a commit that referenced this pull request Jul 10, 2017
Replace `cargo search --host` with `cargo search --index`

This change makes the command consistent with other versions of the same flag. `cargo search --host` is still supported, as well as `cargo search --index <index> --host <host>` in case of confusion. The three commands currently supported should produce the same behavior. All instances of `--host` are currently marked as deprecated, or for reuse as mentioned in issue #4208.

Fixes #4219
@bors
Copy link
Contributor

bors commented Jul 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 2b8de5d to master...

@bors bors merged commit 4d30d52 into rust-lang:master Jul 10, 2017
@natboehm natboehm deleted the add-index-flag-search branch July 10, 2017 18:50
@ehuss ehuss added this to the 1.20.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--host flag in search command wants registry index URL, not registry website host
5 participants