-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sha2 to calculate SHA256 #4545
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks again for the PR! Sorry I didn't quite have enough time to respond on #4542, but I wonder if it'd be possible to just vendor an implementation using common crypto on OSX? I'm somewhat hesitant to move to a Rust-based solution just yet when we've got other crypto libraries in the binary doing it already :( |
@alexcrichton CC: @matklad |
It looks like |
Rustup uses both I definitely want to get rid of manual implementation inside the Cargo itself though! :) |
I've reopened #4542. |
Use sha2 to calculate SHA256 crypto-hash seems to be unmaintained (last real commit on Feb 27, 2020) and forces duplicate crates due to outdated dependencies. Minimal change to replace crypto-hash by sha2. This was already attempted in #4545 (back in 2017).
Supersedes #4542.
This PR will replace FFI libraries for SHA256 calculation with pure-rust implementation.
openssl
andadvapi32-sys
will be removed from dependencies since they are only used for calculating SHA256.