Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for wasm: env WASI_SYSROOT should be optional #1114

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Conversation

NobodyXu
Copy link
Collaborator

On ubuntu-latest github action runner, it used to work without the environment variable.

Fixed #1109 #1113

On ubuntu-latest github action runner, it used to work without the environment variable.

Fixed #1109 #1113
@NobodyXu
Copy link
Collaborator Author

cc @Niederb @Kuuuube Can you try this PR please?

cc @antaalt

@Kuuuube
Copy link
Contributor

Kuuuube commented Jun 30, 2024

I'm still able to replicate the issue using this pr.

@Kuuuube
Copy link
Contributor

Kuuuube commented Jun 30, 2024

Noticed that #1105 had this diff

-                } else if target == "wasm32-wasi"
-                    || target == "wasm32-unknown-wasi"
-                    || target == "wasm32-unknown-unknown"
-                {

The wasm32-unknown-wasi and wasm32-unknown-unknown targets were not added to the targets list. Adding them to the list along with your changes in this PR does fix the issue. (without your PR's changes it throws errors by adding those targets)

Threw in a PR targeting this PR's branch. #1115

If theres anything wrong with my changes in that PR feel free to close it or do whatever.

@NobodyXu NobodyXu merged commit fe9ccd1 into main Jun 30, 2024
48 checks passed
@NobodyXu NobodyXu deleted the fix-wasi branch June 30, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing wasip1 build after upgrade to cc-1.0.100
2 participants