-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting O_NONBLOCK in parallel::stderr::set_non_blocking #946
Conversation
cc @rtyler can you test this please? |
Looks promising to me! |
@rtyler Thanks! I will get this merge and cut a release soon! |
Refactor it to use `parallel::stderr::set_non_blocking`, so that there's only one implementation and it would fix the bug. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Since it would only be useful on Unix. Signed-off-by: Jiahao XU <[email protected]>
… called Signed-off-by: Jiahao XU <[email protected]>
@Mark-Simulacrum gentle reminder to review this - it's blocking updates of cc-rs in the Rust compiler |
@NobodyXu can we please get a release with this change, or do you think it'd be OK to use 1.0.85 (I don't know what the implications of this issue would be) |
Yes I do want to cut a new release, but I'm worried about the regression in #948 |
fix #945