update to edition 2018, allow internal_features #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klensy
changed the title
klensy
force-pushed
the
edition-up
branch
2 times, most recently
from
11a6d9a to
8a39407
Compare
klensy
commented
Aug 7, 2023
klensy
commented
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crate was on 2015 edition, so update to 2018. Can be changed to 2021 (probably not. libm is submodule on 2018 edition, how that worked before?).
Also adds
#![allow(internal_features)]recently added in rust-lang/rust#108955, without it build stops on recent nightly.