Account for optimization levels other than numbers #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes [1], which fixes a bug parsing non-numeric optimization levels. [1]: rust-lang/libm#417
The build script currently panics with `opt-level=z` or `opt-level=s`. Account for this here. This is the `compiler-builtins` version of [1]. Fixes: rust-lang#742 [1]: rust-lang/libm#417
faptc
reviewed
Jan 7, 2025
| @@ -121,7 +121,7 @@ fn configure_libm(target: &Target) { | |||
| } | |||
|
|
|||
| println!("cargo:rustc-check-cfg=cfg(optimizations_enabled)"); | |||
| if target.opt_level >= 2 { | |||
| if !matches!(target.opt_level.as_str(), "0" | "1") { | |||
There was a problem hiding this comment.
For this purpose it is fine, the config is only used in libm's test-related code. I only included it here for consistency if we wind up doing something similar in compiler-builtins/testcrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script currently panics with
opt-level=zoropt-level=s. Account for this here.This is the
compiler-builtinsversion of 1. This PR also includes thelibmsubmodule update with 1, and a few other small changes.Fixes: #742