Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute rustc_codegen_cranelift as rustup component #405

Closed
1 of 3 tasks
bjorn3 opened this issue Feb 2, 2021 · 2 comments
Closed
1 of 3 tasks

Distribute rustc_codegen_cranelift as rustup component #405

bjorn3 opened this issue Feb 2, 2021 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@bjorn3
Copy link
Member

bjorn3 commented Feb 2, 2021

Proposal

Distribute rustc_codegen_cranelift as rustup component on nightly. This makes it possible to use it with -Zcodegen-backend=cranelift on nightly after installing the rustup component.

cc https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Distributing.20cranelift/

Mentors or Reviewers

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@bjorn3 bjorn3 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Feb 2, 2021
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Feb 2, 2021
@jonas-schievink
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 2, 2021
@bjorn3 bjorn3 mentioned this issue Feb 4, 2021
Merged
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 4, 2021
@apiraino apiraino added the major-change-accepted A major change proposal that was accepted label Feb 18, 2021
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Feb 18, 2021
@apiraino apiraino removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 18, 2021
@apiraino apiraino added to-announce Announce this issue on triage meeting and removed to-announce Announce this issue on triage meeting labels Feb 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 22, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=
9567078 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

Marking as draft because I haven't verified that it correctly produces the component. In addition it makes cg_clif compile by default. This may want to be moved to the CI configuration instead.

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 22, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
8a030a8 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

Marking as draft because I haven't verified that it correctly produces the component. In addition it makes cg_clif compile by default. This may want to be moved to the CI configuration instead.

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 22, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
3beacc3 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

Marking as draft because I haven't verified that it correctly produces the component. In addition it makes cg_clif compile by default. This may want to be moved to the CI configuration instead.

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 22, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
69ffe1b 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

Marking as draft because I haven't verified that it correctly produces the component. In addition it makes cg_clif compile by default. This may want to be moved to the CI configuration instead.

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 24, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=Ma…
8cc1470 
…rk-Simulacrum

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 25, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
986298a 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 25, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
0b14d5a 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 26, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=Ma…
d236018 
…rk-Simulacrum,lqd

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 26, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=Ma…
aef0380 
…rk-Simulacrum,lqd

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 27, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
4d3f1db 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 27, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=<try>
4629770 
Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 28, 2023
@bors
Auto merge of rust-lang#81746 - bjorn3:cg_clif_rustup_component, r=Ma…
6a66ca2 
…rk-Simulacrum

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this issue Oct 29, 2023
@bors
Auto merge of #81746 - bjorn3:cg_clif_rustup_component, r=Mark-Simula…
da1ed4d 
…crum

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Nov 2, 2023
@bors
Auto merge of #81746 - bjorn3:cg_clif_rustup_component, r=Mark-Simula…
81a8ccb 
…crum

Distribute cg_clif as rustup component on the nightly channel

This makes it possible to use cg_clif using:

```bash
$ rustup component add rustc-codegen-cranelift-preview --toolchain nightly
$ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build
```

cc rust-lang/compiler-team#405.
r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @apiraino @bjorn3 @rustbot