Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

craterbot should generate unique names for each run #306

Closed
varkor opened this issue Sep 14, 2018 · 2 comments
Closed

craterbot should generate unique names for each run #306

varkor opened this issue Sep 14, 2018 · 2 comments
Labels
A-craterbot Area: craterbot C-enhancement Category: enhancement to an existing feature hacktoberfest

Comments

@varkor
Copy link
Member

varkor commented Sep 14, 2018

See rust-lang/rust#53578 (comment) for context. If the name parameter is not manually specified, it would be useful to disambiguate runs with pr-xxx-n where n is the index of the current crater run. This means that the user will not have to manually specify names for repeat crater runs.
@pietroalbini pietroalbini added C-enhancement Category: enhancement to an existing feature A-craterbot Area: craterbot labels Sep 15, 2018
@devonhollowood
Copy link
Contributor

I'll take a shot at this.

@pietroalbini
Copy link
Member

Thanks! If you have any doubts or questions feel free to ask a question here or ping me on the Rust Discord channel #crater.

@devonhollowood devonhollowood mentioned this issue Oct 5, 2018
Merged
bors added a commit that referenced this issue Oct 11, 2018
@bors
Auto merge of #334 - devonhollowood:auto-increment-default-name, r=pi…
d2e54c1 
…etroalbini

Auto-increment default names for PRs

Fix #306

I thought that the easiest way to go about this was to adjust `default_experiment_name()`, and to just have it automatically try new names in case of a clash until it finds one that works. This makes the assumption that there won't be too too many experiments for a given PR, since experiment `N` will make N calls to the database, which is only really okay if N is small. Let me know if you'd like me to do something smarter here, or to adjust a different area of the code instead.
@bors bors closed this as completed in #334 Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-craterbot Area: craterbot C-enhancement Category: enhancement to an existing feature hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pietroalbini @varkor @devonhollowood