Wait for up to a second for existing database lock to clear #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets users queue new builds and otherwise schedule work while an ongoing run is proceeding (with lots of record-progress hits). Arguably we want to prioritize user-initiated commands to take effect and cancel ongoing record-progress operations (and other automated work), but that will need more care.
|
@bors r+ |
|
📌 Commit 3802622 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 10, 2022
Wait for up to a second for existing database lock to clear This lets users queue new builds and otherwise schedule work while an ongoing run is proceeding (with lots of record-progress hits). Arguably we want to prioritize user-initiated commands to take effect and cancel ongoing record-progress operations (and other automated work), but that will need more care. Should fix cases like rust-lang/rust#94775 (comment), or at least make them much more rare (individual database operations should very rarely take >1s, though our logs do suggest it is not entirely infrequent today. (That's something that's worth looking into, just haven't had time yet). ``` [2022-03-10T16:08:38Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 5.009915144s [2022-03-10T16:08:43Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 5.009725792s [2022-03-10T16:08:46Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 3.235525973s ```
|
💔 Test failed - checks-actions |
|
It looks like the default busy timeout is claimed to be 5 seconds, so this would not actually help. I'm trying to figure out why we're seeing the database is locked error in the first place then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users queue new builds and otherwise schedule work while an ongoing
run is proceeding (with lots of record-progress hits). Arguably we want to
prioritize user-initiated commands to take effect and cancel ongoing
record-progress operations (and other automated work), but that will need more
care.
Should fix cases like rust-lang/rust#94775 (comment),
or at least make them much more rare (individual database operations should very rarely take >1s,
though our logs do suggest it is not entirely infrequent today. (That's something that's worth looking into,
just haven't had time yet).