Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update itertools to 0.7.0 and log to 0.4 #1605

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Update itertools to 0.7.0 and log to 0.4 #1605

merged 2 commits into from
Feb 4, 2019

Conversation

joshleeb
Copy link

@joshleeb joshleeb commented Jan 24, 2019

This PR updates dependency crates itertools to 0.7.0 and log to 0.4.

Ref. #1265

@joshleeb joshleeb changed the title Update itertools to 0.7.0 and log to 0.4.0 Update itertools to 0.7.0 and log to 0.4 Jan 24, 2019
@sgrif
Copy link
Contributor

sgrif commented Jan 24, 2019

It looks like you accidentally updated a lot more than just those two dependencies, which has caused test failures. Did you maybe run cargo update on accident?

@joshleeb
Copy link
Author

Did you maybe run cargo update on accident?

@sgrif I didn't run cargo update. My method was to update the itertools entry in Cargo.toml directly and then run cargo build.

I suspect it is during the build the other versions in the lock file are being updated?

@sgrif
Copy link
Contributor

sgrif commented Jan 26, 2019

You might just want to make sure you've rebased on the latest master, then.

@sgrif
Copy link
Contributor

sgrif commented Jan 26, 2019

Scratch that, this isn't your fault. The author of ring has yanked all versions of their crate including the one that we depend on. Any attempts to change Cargo.toml in any way will now break our build. I'm looking into this now.

@sgrif
Copy link
Contributor

sgrif commented Jan 26, 2019

Update: Any changes to Cargo.toml will need to update Cargo.lock by hand unless the version of ring we depend on is unyanked (opened briansmith/ring#774 to try and get clarification) or we go through and update all of our transitive dependencies that use ring to 0.14. This involves a lot of crates that aren't actively maintained so that would be a major undertaking

@sgrif
Copy link
Contributor

sgrif commented Jan 26, 2019

This is blocked on #1607

@sgrif sgrif added the blocked label Jan 26, 2019
@bors
Copy link
Contributor

bors commented Jan 31, 2019

☔ The latest upstream changes (presumably #1609) made this pull request unmergeable. Please resolve the merge conflicts.

@carols10cents
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2019

📌 Commit a7cbb3d has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Feb 4, 2019

⌛ Testing commit a7cbb3d with merge e418a15...

bors added a commit that referenced this pull request Feb 4, 2019
Update itertools to 0.7.0 and log to 0.4

This PR updates dependency crates `itertools` to 0.7.0 and `log` to 0.4.

Ref. #1265
@bors
Copy link
Contributor

bors commented Feb 4, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing e418a15 to master...

@bors bors merged commit a7cbb3d into rust-lang:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants