Add Fastboot dependencies without enabling them

[kzys]

Fastboot-related dependencies are added by the following "npm install"
commands:

• npm i --save fastboot-app-server
• npm i --save-dev ember-cli-fastboot

But Fastboot itself is disabled by having FASTBOOT_DISABLED=true.

[rust-highfive]

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

[carols10cents]

This works, fastboot installs but nothing changes about running the npm commands locally. FWIW, I also deployed this to staging and the deploy worked and I don't see anything unusual.

Here's the deploy logs if that's interesting:

remote: =====> Downloading Buildpack: https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/emberjs.tgz
remote: =====> Detected Framework: emberjs
remote: -----> Fetching buildpack heroku/nodejs-v98
remote: -----> Node.js detected
remote:
remote: -----> Creating runtime environment
remote:
remote:        NPM_CONFIG_LOGLEVEL=error
remote:        NPM_CONFIG_PRODUCTION=false
remote:        NODE_VERBOSE=false
remote:        NODE_ENV=production
remote:        NODE_MODULES_CACHE=true
remote:
remote: -----> Installing binaries
remote:        engines.node (package.json):  ^12.9.1
remote:        engines.npm (package.json):   ^6.10.2
remote:
remote:        Resolving node version ^12.9.1 via semver.io...
remote:        Downloading and installing node 12.13.0...
remote:        Resolving npm version ^6.10.2 via semver.io...
remote:        Downloading and installing npm 6.13.0 (replacing version 6.12.0)...
remote:
remote: -----> Restoring cache
remote:        Loading 2 from cacheDirectories (default):
remote:        - node_modules
remote:        - bower_components (not cached - skipping)
remote:
remote: -----> Building dependencies
remote:        Installing node modules (package.json)
remote:        added 47 packages from 26 contributors, removed 100 packages, updated 120 packages and audited 161758 packages in 24.968s
remote:
remote: -----> Caching build
remote:        Clearing previous node cache
remote:        Saving 2 cacheDirectories (default):
remote:        - node_modules
remote:        - bower_components (nothing to cache)
remote:
remote: -----> Build succeeded!
remote: -----> Fetching buildpack heroku/ember-cli-deploy
remote: -----> ember-cli detected
remote: -----> Skipping installing bower dependencies, no bower.json detected.
remote: -----> Building ember assets
remote: Browserslist: caniuse-lite is outdated. Please run next command `npm update`
remote: Could not start watchman
remote: Visit https://ember-cli.com/user-guide/#watchman for more info.
remote: - Building
remote: Environment: production
remote: - Building
remote: Browserslist: caniuse-lite is outdated. Please run next command `npm update`
remote: - cleaning up
remote: cleaning up...
remote: - cleaning up
remote: Built project successfully. Stored in "dist/".
remote: File sizes:
remote:  - dist/assets/cargo-2d644da535a237ede17eb9c52c39702f.css: 27.69 KB (5.69 KB gzipped)
remote:  - dist/assets/cargo-adfde58ea848264f9afa3f004722d887.js: 211.47 KB (32.14 KB gzipped)
remote:  - dist/assets/cargo-fastboot-396d88bf1e709bad470c7d0e86edbd6b.js: 1.79 KB (838 B gzipped)
remote:  - dist/assets/vendor-8d023d47762d5431764f589a6012123e.css: 2.77 KB (1.02 KB gzipped)
remote:  - dist/assets/vendor-bfe89101b20262535de5a5ccdc276965.js: 930.5 KB (250.6 KB gzipped)
remote:  - dist/ember-fetch/fetch-fastboot-cb5f9a4ee9840879cc0425db52efb473.js: 790 B (466 B gzipped)
remote:  - dist/moment/fastboot-moment-fc1d02c2a35021ee4ca1a6f87a5a64c7.js: 131 B (120 B gzipped)
remote:  - dist/moment/fastboot-moment-timezone-578ab4bc24839c1fa18fc484b2cf5d0d.js: 140 B (129 B gzipped)
remote: -----> Loading old ember assets
remote: -----> Caching ember assets
remote: -----> ember fastboot detected
remote: -----> Restoring fastboot dependencies
remote: -----> Installing fastboot dependencies
remote: npm notice created a lockfile as package-lock.json. You should commit this file.
remote: npm WARN dist No description
remote: npm WARN dist No repository field.
remote: npm WARN dist No license field.
remote:
remote: audited 5 packages in 0.547s
remote: -----> Caching fastboot dependencies
remote: -----> ember-fastboot command not detected, installing fastboot-cli
remote: npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/sass/node_modules/fsevents):
remote: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
remote: npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
remote: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
remote:
remote: + [email protected]
remote: added 14 packages from 46 contributors and audited 162107 packages in 21.711s

@bors: r+

[bors]

📌 Commit 77856b0 has been approved by carols10cents

[bors]

⌛ Testing commit 77856b0 with merge 21e04f3...

[bors]

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 21e04f3 to master...