-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make /install work under FastBoot #1912
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
What do you think about converting ( |
Sure. I can do that. But please deploy/enable |
I agree, we should enable that first. That change is deployed now, but I don't have the ability to enable it on production, and I can't speak for @carols10cents on when that will be possible. |
The service can be used from other routes that modify window.location.
That makes the routes work under FastBoot.
f1e831d
to
976e8e8
Compare
Looks good to me! This should be safe to deploy at any time, as no changes are made to nginx. @bors r+ |
📌 Commit 976e8e8 has been approved by |
Make /install work under FastBoot Will add nginx.conf change after #1907. Early feedback is welcome!
☀️ Test successful - checks-travis |
Will add nginx.conf change after #1907. Early feedback is welcome!