-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak <noscript> text and placement #2101
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
We might want to still have some kind of message, as some functionality will not be available if you don't have JS enabled. What do you think? |
How about changing the message to something like:
Most users won't see the message at all, and with functionality like the download charts we may not ever reach complete feature parity. We could also move the message to a better place with better styling, as it is currently located in a strange place below the footer. |
If so, we could probably put the message in app/index.html instead of adding this new file. What do you think? |
Yeah, I agree. I'd like to avoid adding another file that we'll need to keep synchronized with app/index.html. |
After having FastBoot, JavaScript would not be "required" but still necessary for full functionality of crates.io
LGTM! I've updated the PR subject and text to reflect the changes. @bors r+ |
📌 Commit 2ef458e has been approved by |
Tweak <noscript> text and placement After having FastBoot, JavaScript would not be "required" but still necessary for full functionality of crates.io.
☀️ Test successful - checks-travis |
After having FastBoot, JavaScript would not be "required" but still
necessary for full functionality of crates.io.