Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /me/tokens: Return crate_scopes and endpoint_scopes fields too #6315

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 12, 2023

#5973 already changed this endpoint to accept these fields in the request payload, but the endpoint did not return them again in the response. #6310 changed the corresponding GET endpoint to return these fields in the response, and now this PR here is adding them to the PUT response too.

Note that these fields are considered experimental and we don't give any stability guarantees for now!

Related:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Apr 12, 2023
@Turbo87 Turbo87 enabled auto-merge April 12, 2023 14:42
Turbo87 added 3 commits April 12, 2023 16:51
… testing

Using insta ensures that tests will fail if we unintentionally change anything about the serialization format (e.g. adding token scopes fields 😉)
@Turbo87 Turbo87 force-pushed the returned-token-scopes branch from 96904dd to 0c180e5 Compare April 12, 2023 14:54
@Turbo87 Turbo87 merged commit 9d0f916 into rust-lang:master Apr 12, 2023
@Turbo87 Turbo87 deleted the returned-token-scopes branch April 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant