Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit crate names to 64 characters #718

Merged
merged 4 commits into from
May 8, 2017
Merged

Limit crate names to 64 characters #718

merged 4 commits into from
May 8, 2017

Conversation

carols10cents
Copy link
Member

Fixes #696.

@carols10cents
Wrap valid_name in valid_ident for valid_feature_name
ecc92b1 
I'm about to add another condition to whether a crate name is valid or
not that doesn't apply to feature names. Feature names really only want
to know if something is a valid identifier.
@carols10cents
Not sure how this test works if we log out
a300575 
But it's definitely passing now, I guess we're checking crate names
before checking if there's a valid user???
@carols10cents
Limit crate names to 64 characters. Fixes rust-lang#696.
bff48ce
@carols10cents
Improve the invalid crate name error message
de37d5b 
To explain what a valid crate name is.
@alexcrichton alexcrichton merged commit 9ec474c into rust-lang:master May 8, 2017
@ctaggart ctaggart mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carols10cents @alexcrichton