Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Adds "ICE with rustc --version | false" ICE #5

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

bltavares
Copy link
Contributor

Reference: rust-lang/rust#14505

I was unsure if it would be better to write the Rust code on the comments, but covering rustc --version case seems to be a broader acceptance, as includes the compiler command itself to be fixed.

steveklabnik added a commit that referenced this pull request Oct 23, 2015
Adds "ICE with `rustc --version | false`" ICE
@steveklabnik steveklabnik merged commit ef7e4b1 into rust-lang:master Oct 23, 2015
@steveklabnik
Copy link
Member

I like it. Thanks!

@tbu-
Copy link

tbu- commented Nov 6, 2015

Your commit says | false and the code says | true. I guess it doesn't matter. :)

@steveklabnik
Copy link
Member

hehe yeah, it shouldn't matter either way

@bltavares
Copy link
Contributor Author

I've passed true because of the error code it returns. If it is true, when the bug is fixed it will cause the build to fail, instead of adding a not of the branching.

Would you want it to be closer to the reported error instead? I could do that later this weekend.

On November 6, 2015 4:22:31 PM GMT-02:00, Steve Klabnik [email protected] wrote:

hehe yeah, it shouldn't matter either way


Reply to this email directly or view it on GitHub:
#5 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants