Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ahash 0.8 #357

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Upgrade to ahash 0.8 #357

merged 1 commit into from
Sep 9, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Sep 1, 2022

This changes the default hasher to use a fixed key by default and removes the dependency on getrandom. This is fine since hashbrown has never made any guarantees about HashDoS resistance in its default hasher.

Users who require HashDoS resistance should explicitly use ahash::RandomState or std::collections::hash_map::RandomState as the hasher when creating a HashMap.

Fixes #356

@Amanieu
Copy link
Member Author

Amanieu commented Sep 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit 597c276 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 9, 2022

⌛ Testing commit 597c276 with merge ea7c3ba...

@bors
Copy link
Contributor

bors commented Sep 9, 2022

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing ea7c3ba to master...

@bors bors merged commit ea7c3ba into rust-lang:master Sep 9, 2022
bors added a commit that referenced this pull request Oct 9, 2022
Documentation fix due to latest changes in the crate.

Due to merged PR #357, #362 I think that we need to fix docummentation.

 Fixed broken links in `HashMap::raw_table` and `HashSet::raw_table`, as well as some typos and mistakes elsewhere (especially in `EntryRef::or_insert_with_key`).

To fix #349, I removed capacity comparisons in all places (except `drain` and `clear`),  however left the phrase "keeps the allocated memory for reuse", because although the `erase` method may not release the capacity, the subsequent `rehash_in_place` function definitely will release all.

Close #349.
Manishearth added a commit to Manishearth/hashbrown that referenced this pull request Feb 8, 2024
Manishearth added a commit to Manishearth/hashbrown that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashbrown fails to compile on avr architectures because ahash does not yet support atomic-polyfill
2 participants