-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epoll event constants should be declared as u32 #3462
Comments
Taking a look at the kernel source itself, all values are of type And the __poll_t type is
|
Feel free to open a PR :) |
Well, I can create a pull request with the straightforward s/// easily. However, I'm completely unsure of the further ramifications of this change. So I would really appreciate it if other people approach this request with due care :p |
…Titor update epoll constants to match epoll_event struct Change the type of the EPOLL* event constants to match the type of the events field in struct epoll_event (i.e. u32). closes: #3462
Change the type of the EPOLL* event constants to match the type of the events field in struct epoll_event (i.e. u32). closes: rust-lang#3462
The current implementation declares all EPOLL* event constants as
c_int
, but this isn't very useful given that the accompanying field in struct epoll_event is declared as u32.This makes using these constants very unergonomic:
The first thing every user of these constants will do is redefine them as u32. Can this be done in the libc crate itself? This applies to all EPOLL* event descriptors and input flags, but not the EPOLL_CTL_* operation constants.
The text was updated successfully, but these errors were encountered: