Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dox mess - correction #1259

Closed
wants to merge 1 commit into from

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Feb 14, 2019

unbreak openbsd after 7ac0fe5 a } was missing

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 14, 2019

@bors: r+

FYI I have a PR in the pipeline that uses xargo to compile libc+libcore on targets that do not ship a std component on CI. Hopefully after that's merged you won't have to send these kinds of PRs anymore :)

@bors
Copy link
Contributor

bors commented Feb 14, 2019

📌 Commit f8466b6 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Feb 14, 2019

⌛ Testing commit f8466b6 with merge 55622dd...

bors added a commit that referenced this pull request Feb 14, 2019
Cleanup dox mess - correction

unbreak openbsd after 7ac0fe5 a `}` was missing
@bors
Copy link
Contributor

bors commented Feb 14, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 18, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 18, 2019

⌛ Testing commit f8466b6 with merge 666488d...

bors added a commit that referenced this pull request Feb 18, 2019
Cleanup dox mess - correction

unbreak openbsd after 7ac0fe5 a `}` was missing
@bors
Copy link
Contributor

bors commented Feb 18, 2019

💔 Test failed - checks-cirrus

bors added a commit that referenced this pull request Feb 20, 2019
Test that targets without a shipping libcore / libstd build properly

This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`.

This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259).

cc @asomers @strangelittlemonkey @semarie
@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 20, 2019

@semarie Thank you for the PR, I'm closing it because this should be fixed by #1263 , which should prevent this from breaking again, and also generate docs for openbsd (we'll see if the docs part works out).

@gnzlbg gnzlbg closed this Feb 20, 2019
bors added a commit that referenced this pull request Feb 20, 2019
Test that targets without a shipping libcore / libstd build properly

This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`.

This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259).

cc @asomers @strangelittlemonkey @semarie
bors added a commit that referenced this pull request Feb 20, 2019
Test that targets without a shipping libcore / libstd build properly

This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`.

This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259).

cc @asomers @strangelittlemonkey @semarie
bors added a commit that referenced this pull request Feb 20, 2019
Test that targets without a shipping libcore / libstd build properly

This PR tests that `libc` builds on targets that currently don't ship a `libcore`/`libstd` by cross-compiling to them from Linux and MacOSX using `Xargo`.

This fixes the build on DragonflyBSD (superseeds #1237), Haiku, bitrig, and OpenBSD (superseeds #1259).

cc @asomers @strangelittlemonkey @semarie
@semarie semarie deleted the openbsd-unbreak branch August 22, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants