Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libc_const_extern_fn implicitly from Rust 1.62 #2820

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jun 8, 2022

const_extern_fn for "C" has been stabilized since 1.62: rust-lang/rust#95346
This enables the const-extern-fn feature implicitly from 1.62, but leaves the crate feature as-is for compatibility and old nightlies.
Closes #2785

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Jun 8, 2022

@bors r+

@JohnTitor JohnTitor force-pushed the 1-62-const-extern-fn branch from 4677890 to 4a84f34 Compare June 9, 2022 10:26
@JohnTitor
Copy link
Member Author

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Jun 9, 2022

📌 Commit 4a84f34 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jun 9, 2022

⌛ Testing commit 4a84f34 with merge 4042ce2...

@bors
Copy link
Contributor

bors commented Jun 9, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 4042ce2 to master...

@bors bors merged commit 4042ce2 into rust-lang:master Jun 9, 2022
@JohnTitor JohnTitor deleted the 1-62-const-extern-fn branch June 9, 2022 12:31
smoelius added a commit to trailofbits/dylint that referenced this pull request Aug 4, 2022
smoelius added a commit to trailofbits/dylint that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants