Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hurd: Use more standard types #3733

Merged
merged 1 commit into from
Jun 15, 2024
Merged

hurd: Use more standard types #3733

merged 1 commit into from
Jun 15, 2024

Conversation

sthibaul
Copy link
Contributor

@sthibaul sthibaul commented Jun 4, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JohnTitor JohnTitor added this pull request to the merge queue Jun 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 8, 2024
@JohnTitor JohnTitor added this pull request to the merge queue Jun 15, 2024
Merged via the queue into rust-lang:main with commit d479974 Jun 15, 2024
41 checks passed
sthibaul added a commit to sthibaul/libc that referenced this pull request Nov 11, 2024
@sthibaul
hurd: Use more standard types
7497d0e 
(backport <rust-lang#3733>)
(cherry picked from commit e2fd4d3)
@sthibaul sthibaul mentioned this pull request Nov 11, 2024
Merged
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 12, 2024
@sunfishcode
Copy link
Member

Could you also remove hurd's custom type for ssize_t as well? ssize_t is an alias for isize on all targets supported in the libc crate except hurd right now.

@sthibaul
Copy link
Contributor Author

I have created #4029

@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sthibaul @rustbot @sunfishcode @JohnTitor @tgross35