Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd adding execvpe support from 14.1 release #3745

Merged
merged 1 commit into from
Aug 13, 2024
Merged

freebsd adding execvpe support from 14.1 release #3745

merged 1 commit into from
Aug 13, 2024

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Jun 9, 2024

close #3730

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 reviewed Aug 12, 2024
View reviewed changes
src/unix/bsd/freebsdlike/freebsd/mod.rs Outdated
@@ -5462,6 +5462,12 @@ extern "C" {
) -> ::c_int;
pub fn closefrom(lowfd: ::c_int);
pub fn close_range(lowfd: ::c_uint, highfd: ::c_uint, flags: ::c_int) -> ::c_int;

pub fn execvpe(
name: *const ::c_char,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called file per https://man.freebsd.org/cgi/man.cgi?query=execvp

@tgross35
Copy link
Contributor

Changes look good to me with one nit. Could you target main?

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2024

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Some changes occurred in OpenBSD module

cc @semarie

@devnexen devnexen changed the base branch from libc-0.2 to main August 12, 2024 20:05
@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge August 12, 2024 20:13
@tgross35 tgross35 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into rust-lang:main with commit 4e38256 Aug 13, 2024
40 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 17, 2024
@devnexen @tgross35
freebsd adding execvpe support from 14.1 release
0ef0cfd 
(backport <rust-lang#3745>)
(cherry picked from commit 67d062f)
@tgross35 tgross35 mentioned this pull request Aug 17, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 17, 2024
@devnexen @tgross35
freebsd adding execvpe support from 14.1 release
20a1175 
(backport <rust-lang#3745>)
[resolve conflicts - Trevor]
(cherry picked from commit 67d062f)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing execvpe on FreeBSD >= 14.1
4 participants
@devnexen @rustbot @tgross35 @JohnTitor