vxWorks adding few errnoLib related constants. #3780
Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
devnexen
force-pushed
the
vxworks_basic_errors
branch
from
fafae65 to
a7f3de0
Compare
|
rust-lang/rust#128751 makes use of |
|
I m unsure it s possible yet due to the uncertainty of its value unless a minimum vxworks release is supported. |
|
It may be worth specifying a minimum version, even if old, to make it obvious which APIs can be relied upon. If you are up for this, just make a PR to document some minimum version in https://github.com/rust-lang/rust/blob/60d146580c10036ce89e019422c6bc2fd9729b65/src/doc/rustc/src/platform-support/vxworks.md. Then we can ping a handful of people who have been involved in VxWorks to get their feedback. |
src/vxworks/mod.rs
Outdated
| // errnoLib.h | ||
| const taskErrorBase: ::c_int = 0x00030000; | ||
| const semErrorBase: ::c_int = 0x00160000; | ||
| const objErrorBase: ::c_int = 0x003d0000; |
There was a problem hiding this comment.
Did not find these constants in errnoLib.h. Which VxWorks workbench did you use for reference?
There was a problem hiding this comment.
they do not exist, see they re not exposed it s only to serve as base for constants such as :
pub const S_taskLib_NAME_NOT_FOUND: ::c_int = taskErrorBase + 0x0065;
There was a problem hiding this comment.
Ok. Can you change the comments. None of the constants are defined in errnoLib.h
devnexen
force-pushed
the
vxworks_basic_errors
branch
from
a7f3de0 to
ad48151
Compare
src/vxworks/mod.rs
Outdated
| // errnoLib.h | ||
| pub const S_taskLib_NAME_NOT_FOUND: ::c_int = taskErrorBase + 0x0065; | ||
| pub const S_taskLib_TASK_HOOK_TABLE_FULL: ::c_int = taskErrorBase + 0x0066; | ||
| pub const S_taskLib_TASK_HOOK_NOT_FOUND: ::c_int = taskErrorBase + 0x0067; | ||
| pub const S_taskLib_ILLEGAL_PRIORITY: ::c_int = taskErrorBase + 0x0068; |
There was a problem hiding this comment.
These are defined in taskLibCommon.h
There was a problem hiding this comment.
oh I see I confused with vxWorks 6. fixing.
| pub const S_semLib_INVALID_STATE: ::c_int = semErrorBase + 0x0065; | ||
| pub const S_semLib_INVALID_OPTION: ::c_int = semErrorBase + 0x0066; | ||
| pub const S_semLib_INVALID_QUEUE_TYPE: ::c_int = semErrorBase + 0x0067; | ||
| pub const S_semLib_INVALID_OPERATION: ::c_int = semErrorBase + 0x0068; |
There was a problem hiding this comment.
These are defined in semLibCommon.h
| pub const S_objLib_OBJ_ID_ERROR: ::c_int = objErrorBase + 0x0001; | ||
| pub const S_objLib_OBJ_UNAVAILABLE: ::c_int = objErrorBase + 0x0002; | ||
| pub const S_objLib_OBJ_DELETED: ::c_int = objErrorBase + 0x0003; | ||
| pub const S_objLib_OBJ_TIMEOUT: ::c_int = objErrorBase + 0x0004; | ||
| pub const S_objLib_OBJ_NO_METHOD: ::c_int = objErrorBase + 0x0005; |
devnexen
force-pushed
the
vxworks_basic_errors
branch
from
ad48151 to
7a28fc7
Compare
|
CI has some known problems. We're working on getting those sorted out (will need to do that before merge) |
Does that work now with the minimum version of 7? |
devnexen
force-pushed
the
vxworks_basic_errors
branch
from
f248ae8 to
8472900
Compare
Yes. VX_TASK_NAME_LEN is now 31. |
|
it had been added in the last commit |
devnexen
force-pushed
the
vxworks_basic_errors
branch
from
8472900 to
73a6a03
Compare
|
Not going to block on this since it is tier 3, but it may be worth adding a vxworks file in |
tgross35
added
the
stable-nominated
(backport <rust-lang#3780>) (cherry picked from commit 73a6a03)
(backport <rust-lang#3780>) (cherry picked from commit 73a6a03)
tgross35
removed
the
stable-nominated
tgross35
added
the
stable-applied
No description provided.