Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hurd: Add missing struct __timeval for 64bit support #3786

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sthibaul
Copy link
Contributor

This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit architectures.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
@tgross35
Copy link
Contributor

Can you post a link to the relevant docs/source here? libc-test/semver should probably also get a new hurd file with this struct (more can be added later) if you are able to run the test.

@rustbot author

@sthibaul
Copy link
Contributor Author

Can you post a link to the relevant docs/source here?

As mentioned, this is exactly the same as linux with glibc: https://github.com/rust-lang/libc/blob/main/src/unix/linux_like/linux/gnu/mod.rs#L75

for the same reason: the ut_tv field of struct utmpx uses it in the 64bit case: https://github.com/rust-lang/libc/blob/main/src/unix/linux_like/linux/gnu/mod.rs#L584 and https://github.com/rust-lang/libc/blob/main/src/unix/hurd/mod.rs#L1058

because glibc uses a 32-bit-compatible timeval for that field: https://sourceware.org/git/?p=glibc.git;a=blob;f=bits/utmp.h;h=27cb536800c46d67c0627dddb66db4ad737d356f;hb=HEAD#l72

libc-test/semver should probably also get a new hurd file with this struct

We don't have a hurd file there for now.

This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit
architectures.
@tgross35
Copy link
Contributor

Thanks for the follow up, sounds reasonable to me.

@tgross35 tgross35 enabled auto-merge August 16, 2024 09:26
@tgross35 tgross35 added this pull request to the merge queue Aug 16, 2024
Merged via the queue into rust-lang:main with commit bc3c8cb Aug 16, 2024
39 checks passed
@sthibaul sthibaul deleted the hurd64 branch August 16, 2024 11:53
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit
architectures.

(backport <rust-lang#3786>)
(cherry picked from commit c8f2b3c)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit
architectures.

(backport <rust-lang#3786>)
(cherry picked from commit c8f2b3c)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit
architectures.

(backport <rust-lang#3786>)
(cherry picked from commit c8f2b3c)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
This is the same as linux_like/linux/gnu's __timeval for ut_tv for 64bit
architectures.

(backport <rust-lang#3786>)
(cherry picked from commit c8f2b3c)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants