Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Debug impls from tpacket_* structs #3837

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

nathaniel-bennett
Copy link
Contributor

Removes Debug implementation from tpacket_req_u, tpacket_bd_header_u and tpacket_block_desc to avoid potential uninitialized memory access (noted in #3540).

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 17, 2024
@tgross35
Copy link
Contributor

Thanks, I will merge this as-is to main. For the backport I'm just going to change the Debug impls to print ... or something without accessing the fields, so we don't actually break any API that relies on this derive.

@tgross35 tgross35 added this pull request to the merge queue Aug 17, 2024
Merged via the queue into rust-lang:main with commit 23270dd Aug 17, 2024
39 checks passed
@nathaniel-bennett
Copy link
Contributor Author

nathaniel-bennett commented Aug 17, 2024

The backport of the original commit is actually still pending merge (see #3540); I've gone ahead and removed the Debug impls there already 👍

@tgross35
Copy link
Contributor

Oh thanks, I'm getting getting some of the ongoing changes confused and thinking this was existing.

@tgross35 tgross35 removed the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants