Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the TCP_FUNCTION_BLK and TCP_FUNCTION_ALIAS socket options #4047

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Nov 15, 2024

For FreeBSD only

Description

These two socket options are used to get and set a socket's TCP stack, on FreeBSD only.

Sources

https://man.freebsd.org/cgi/man.cgi?query=tcp
https://github.com/freebsd/freebsd-src/blob/976e1d36be688166e140cbaded01d433c61e6d47/sys/netinet/tcp.h#L229

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@asomers
Copy link
Contributor Author

asomers commented Nov 16, 2024

The error looks unrelated to my change. For one thing, it was a Linux build that failed. For another, this is the error:

rustc-LLVM ERROR: Cannot select: 0x7fe87eb15000: f32,ch = load<(load (s16) from %ir.0), anyext from f16> 0x7fe87eb15a10, 0x7fe87eaf6540, undef:i64, src/fmt/float.rs:238:30
  0x7fe87eaf6540: i64,ch = CopyFromReg 0x7fe87eabb468, Register:i64 %0
    0x7fe87eb15af0: i64 = Register %0
  0x7fe87eb155b0: i64 = undef
In function: _ZN4core3fmt5float50_$LT$impl$u20$core..fmt..Debug$u20$for$u20$f16$GT$3fmt17h9203c7e9bc0be64fE
error: could not compile `core` (lib)

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error looks unrelated to my change. For one thing, it was a Linux build that failed. For another, this is the error:

rustc-LLVM ERROR: Cannot select: 0x7fe87eb15000: f32,ch = load<(load (s16) from %ir.0), anyext from f16> 0x7fe87eb15a10, 0x7fe87eaf6540, undef:i64, src/fmt/float.rs:238:30
  0x7fe87eaf6540: i64,ch = CopyFromReg 0x7fe87eabb468, Register:i64 %0
    0x7fe87eb15af0: i64 = Register %0
  0x7fe87eb155b0: i64 = undef
In function: _ZN4core3fmt5float50_$LT$impl$u20$core..fmt..Debug$u20$for$u20$f16$GT$3fmt17h9203c7e9bc0be64fE
error: could not compile `core` (lib)

That was just a bug on the most recent nightly, I think it should be fixed with the one that just released.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 16, 2024
@tgross35 tgross35 enabled auto-merge November 16, 2024 05:08
@tgross35 tgross35 added this pull request to the merge queue Nov 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
For FreeBSD only

(backport <rust-lang#4047>)
(cherry picked from commit 2e8be88)
@tgross35 tgross35 mentioned this pull request Nov 16, 2024
Merged via the queue into rust-lang:main with commit 121f28a Nov 16, 2024
43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
For FreeBSD only

(backport <rust-lang#4047>)
(cherry picked from commit 2e8be88)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
For FreeBSD only

(backport <rust-lang#4047>)
(cherry picked from commit 2e8be88)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 16, 2024
For FreeBSD only

(backport <rust-lang#4047>)
(cherry picked from commit 2e8be88)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants