-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add various PTP_
consts
#4114
Merged
Merged
add various PTP_
consts
#4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
add-ptp-clock-consts
branch
8 times, most recently
from
November 20, 2024 10:33
765595e
to
b8fcecf
Compare
☔ The latest upstream changes (presumably #4113) made this pull request unmergeable. Please resolve the merge conflicts. |
folkertdev
force-pushed
the
add-ptp-clock-consts
branch
2 times, most recently
from
November 20, 2024 10:59
236f488
to
5a41ff2
Compare
We cannot (apparently) use a type alias for `ptp_pin_function` because CI is unhappy with that (e.g. https://github.com/rust-lang/libc/actions/runs/11921706273/job/33226419934?pr=4114) We can always add that type alias later; it's not a breaking change
folkertdev
force-pushed
the
add-ptp-clock-consts
branch
from
November 20, 2024 16:06
5a41ff2
to
a2ec642
Compare
this is everything except for |
tgross35
added
the
stable-nominated
This PR should be considered for cherry-pick to libc's stable release branch
label
Nov 20, 2024
tgross35
approved these changes
Nov 20, 2024
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 25, 2024
We cannot (apparently) use a type alias for `ptp_pin_function` because CI is unhappy with that (e.g. https://github.com/rust-lang/libc/actions/runs/11921706273/job/33226419934?pr=4114) We can always add that type alias later; it's not a breaking change (backport <rust-lang#4114>) (cherry picked from commit a2ec642)
Merged
tgross35
added
stable-applied
This PR has been cherry-picked to libc's stable release branch
and removed
stable-nominated
This PR should be considered for cherry-pick to libc's stable release branch
labels
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-linux
O-unix
S-waiting-on-review
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants from #3865, hopefully.
Description
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
r? @tgross35