-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not use system dylib when cross-compiling on macOS #84
Comments
Detection whether |
Similar issue when cross-compiling to iOS. iOS has libz shared library. |
I don't think this is fixed. As a matter of fact I have a cross-compile job that ends up compiling zlib (and failing, because it's using clang trunk, which broke building zlib < 1.3.1). |
There is now v1.1.15 of |
Really fixes rust-lang#84. This is what rust-lang#85 intended, as far as I can tell, but the logic was such that it didn't work for cross-compiles from e.g. Linux (apple_to_apple would be false, leading to the build_zlib path being taken)
macOS has fat binary dylibs with executable code for multiple architectures. When cross-compiling between macOS on x86 and ARM, all system libraries are usable on both architectures, including libz.1.dylib.
The current logic gives up on system zlib when
target != host
, which causes unnecessary static linking when the target and host arex86_64-apple-darwin
andaarch64-apple-darwin
.The text was updated successfully, but these errors were encountered: