Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport [TailCallElim] Remove the readonly attribute of byval. #150

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Backport [TailCallElim] Remove the readonly attribute of byval. #150

merged 3 commits into from
Aug 10, 2023

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Aug 8, 2023

DianQK added 2 commits August 9, 2023 07:27
@DianQK
[TailCallElim] Regenerate test checks with --function-signature (NFC)
661b8e4 
For checking the readonly attribute.

Pre-commit test for D156793.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D156789

(cherry picked from commit b77e556)
@DianQK
[TailCallElim] Remove the readonly attribute of byval.
f67d165 
When eliminating a tail call, we modify the values of the arguments.
Therefore, if the byval parameter has a readonly attribute, we have to remove it. It is safe because,
from the perspective of a caller, the byval parameter is always treated as "readonly," even if the readonly attribute is removed.

Fixes llvm#64289.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D156793

(cherry picked from commit c3f227e)
@cuviper
Copy link
Member

cuviper commented Aug 8, 2023

We just updated to LLVM 17 in rust-lang/rust#114048, local branch rustc/17.0-2023-07-29.

Ideally, we would just pick this up after it's backported to the upstream release/17.x.

@DianQK
Copy link
Member Author

DianQK commented Aug 9, 2023

Ideally, we would just pick this up after it's backported to the upstream release/17.x.

I will backport to release/17.x. Because this is a miscompilation, I expect to backport to rust beta (1.72.0).

@cuviper cuviper mentioned this pull request Aug 9, 2023
Closed
@cuviper
Copy link
Member

cuviper commented Aug 9, 2023

Because this is a miscompilation, I expect to backport to rust beta (1.72.0).

I nominated the rust issue for T-compiler discussion.

@DianQK
Revert "[clang][WebAssembly] Support wasm32-wasi shared libraries"
5c4799e 
This reverts commit a7d11c4.

We just want to update the beta branch with the necessary fixes.
This branch rustc/16.0-2023-06-05 has completed its mission on the
master branch.
So we can revert this commit for beta updates.
@DianQK
Copy link
Member Author

DianQK commented Aug 10, 2023

Revert "[clang][WebAssembly] Support wasm32-wasi shared libraries"

We just want to update the beta branch with the necessary fixes.
This branch rustc/16.0-2023-06-05 has completed its mission on the
master branch.
So we can revert this commit for beta updates.

@cuviper
Copy link
Member

cuviper commented Aug 10, 2023

Thanks!

@cuviper cuviper merged commit c9bca8a into rust-lang:rustc/16.0-2023-06-05 Aug 10, 2023
@DianQK DianQK deleted the rustc/16.0-2023-06-05 branch August 11, 2023 02:57
vext01 pushed a commit to vext01/llvm-project that referenced this pull request May 9, 2024
@ltratt
Merge pull request rust-lang#150 from vext01/vlmap-tweak
d0314d6 
Yk IR serialiser: Simplify the value lowering map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DianQK @cuviper