Cherry pick: Revert "[InlineCost] Check for conflicting target attributes early" #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d6f994a. Several people have reported breakage resulting from this patch: - llvm#65152 - llvm#65205
|
Please always file for upstream backport first. I have now done so in llvm#65205 (comment). |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2023
Update LLVM submodule Update LLVM submodule to pull in additional 17.x backports. Fixes rust-lang#115970. Fixes miscompile from rust-lang#115554. Fixes miscompile from rust-lang#102099. Fixes inlining regressions mentioned at rust-lang/llvm-project#153.
|
Now that this landed upstream, can it be cherry-picked? |
|
It was already included when Nikita merged the upstream |
|
Ah thanks, it's in https://github.com/rust-lang/llvm-project/tree/rustc/17.0-2023-09-19. |
vext01
pushed a commit
to vext01/llvm-project
that referenced
this pull request
May 13, 2024
Reject `getelementptr` instructions we don't yet handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose cherry-picking llvm@b4301df which is the revert/fix for an issue discussed in llvm#65205.
Without this revert we've noticed a lot of inlining failures when compiling for the BPF target. Credit to @qjerome for helping track down the issue.