Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I was trying to wrap a
Box<dyn Log>
returned from flexi logger into async_log but I was unable to do so since theLog
trait was not implemented forBox<dyn Log>
.One option was to create a wrapper struct:
It was suggested to me that it might be beneficial to have the implementation in the log crate so I've added the implementation in this pull request.
Would you accept this change? I will be happy to make any changes or modifications if necessary.