refactor: Use axum for "mdbook serve" #2359
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in my opinion brings mdbook's dependencies more in line with "the state of the art" of the Rust HTTP ecosystem.
It pulls in
hyper v1
and usestower-http
for filesystem serving functions.I've manually tested serve with the
test_book
:I can't guarantee though that there are no regressions. I did not find integrations tests for the serve command.