refactor: inline packages for decoding v7 and v8 profdata files #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
…@9.2.0 Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
Signed-off-by: Weihang Lo <[email protected]>
|
@michaelwoerister this is ready for review, though I am not sure if this is better than releasing old versions to crates.io 😅. |
weihanglo
changed the title
Yes indeed. Looking at the size of the diff, I'm not so sure anymore either. I had overlooked that we also need to make a copy of the whole StringTable code. Frankly, I'd prefer if we kept things as they are and just released the old versions to crates.io. Backporting the license file changes is a one-time effort. |
|
Close as this is way more a headache than depending on old versions, and this approach is favored: #229 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step toward making rustc-perf self-contained.
See:
This is basically a slim version of vendoring older versions of those packages.
This is done by first vendoring, and then incrementally remove unused code.
Code is not shared between each version.