Skip to content

Commit

Permalink
Auto merge of #1346 - RalfJung:dyn-layout-test, r=RalfJung
Browse files Browse the repository at this point in the history
Test that we enforce dynamic layout properties (not just static ones of sized prefix)
  • Loading branch information
bors committed Apr 18, 2020
2 parents 216e686 + c6ab275 commit 3d6d35c
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
13 changes: 13 additions & 0 deletions tests/compile-fail/dangling_pointers/dyn_size.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// should find the bug even without these
// compile-flags: -Zmiri-disable-validation -Zmiri-disable-stacked-borrows

struct SliceWithHead(u8, [u8]);

fn main() {
let buf = [0u32; 1];
// We craft a wide pointer `*const SliceWithHead` such that the unsized tail is only partially allocated.
// That should be UB, as the reference is not fully dereferencable.
let ptr: *const SliceWithHead = unsafe { std::mem::transmute((&buf, 4usize)) };
// Re-borrow that. This should be UB.
let _ptr = unsafe { &*ptr }; //~ ERROR pointer must be in-bounds at offset 5
}
19 changes: 19 additions & 0 deletions tests/compile-fail/unaligned_pointers/dyn_alignment.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// should find the bug even without these
// compile-flags: -Zmiri-disable-validation -Zmiri-disable-stacked-borrows

#[repr(align(256))]
#[derive(Debug)]
struct MuchAlign;

fn main() {
let buf = [0u32; 256];
// `buf` is sufficiently aligned for `layout.align` on a `dyn Debug`, but not
// for the actual alignment required by `MuchAlign`.
// We craft a wide reference `&dyn Debug` with the vtable for `MuchAlign`. That should be UB,
// as the reference is not aligned to its dynamic alignment requirements.
let mut ptr = &MuchAlign as &dyn std::fmt::Debug;
// Overwrite the data part of `ptr` so it points to `buf`.
unsafe { (&mut ptr as *mut _ as *mut *const u8).write(&buf as *const _ as *const u8); }
// Re-borrow that. This should be UB.
let _ptr = &*ptr; //~ ERROR accessing memory with alignment 4, but alignment 256 is required
}

0 comments on commit 3d6d35c

Please sign in to comment.