Skip to content

Commit

Permalink
Auto merge of #127442 - saethlin:alloc-decoding-lock, r=oli-obk
Browse files Browse the repository at this point in the history
Try to fix ICE from re-interning an AllocId with different allocation contents

As far as I can tell, based on my investigation in rust-lang/rust#126741, the racy decoding scheme implemented here was never fully correct, but the arrangement of Allocations that's required to ICE the compiler requires some very specific MIR optimizations to create. As far as I can tell, GVN likes to create the problematic pattern, which is why we're noticing this problem now.

So the solution here is to not do racy decoding. If two threads race to decoding an AllocId, one of them is going to sit on a lock until the other is done.
  • Loading branch information
bors committed Jul 22, 2024
2 parents dfc10eb + 92fa7a8 commit 8f04a1f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 8f04a1f

Please sign in to comment.