-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should ./miri run
set a default edition?
#2999
Comments
Having to specify the latest edition is really annoying; we should probably default to the latest. That's what the playground and godbolt do. |
We could do that at the miri level if we wanted to. We don't have to follow rustc's CLI exactly |
I think I'd rather keep the miri binary matching rustc. |
With the changes in rust-lang/rust#118692, more files will stop working with the 2015 edition. I think we can just start with a single heuristic: if we don't find I wish rustc would just use the last flag when there are multiple |
./miri run: default to edition 2021 Fixes rust-lang/miri#2999
./miri run: default to edition 2021 Fixes rust-lang/miri#2999
./miri run: default to edition 2021 Fixes rust-lang/miri#2999
./miri run
fails on a bunch of our test files since they require a newer edition. Maybe we should add--edition 2021
or so to the flags (matching the edition used for our tests)? This does mean users cannot set an edition themselves any more, but that should rarely be required. (And we could also inhibit this flag if we see a user-passed--edition
.)The text was updated successfully, but these errors were encountered: