Make r? work in our PRs

[RalfJung]

Is there a way that we can get r? to work without automatic reviewer assignment?

[tiif]

Since the documentation mentioned this:

Ghost

Using r? ghost in the initial PR top-level comment when opening a PR will disable triagebot’s auto-assignment. ghost is GitHub’s placeholder account for deleted accounts. It is used here for convenience. This is typically used for rollups or experiments where you don’t want any assignments or noise.

I wonder if a hack like below would work?

[assign.adhoc_groups]
miri = ["@username1", "@username2", "@username3"]

# Triagebot will pick one person from here to assign
[assign.owners]
# match all file with "*"
"*" = ["@ghost"]

When looking up a name, triagebot will first look at ad-hoc groups, then rust-lang teams, and if it doesn’t match either of those it assumes it is a GitHub user.

assign.adhoc_groups is to choose a random person from the miri team by using r? miri, and r? @username1 will work without any configuration.

source: triagebot pr assignment documentation

[RalfJung]

I would have hoped that just not having any owners would do it, but currently we can't use r? at all for some reason...

[tiif]

hmm, strange. I'd like to test if @rustbot claim would work here too.

[rustbot]

Error: Parsing assign command in comment failed: ...' claim' | error: expected end of command at >| ' would wor'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[tiif]

Uh oh... @rustbot claim

[tiif]

Nice @rustbot release-assignment

[RalfJung]

I think this is blocked on triagebot improvements:

• "r?" silently does nothing when the user is not a reviewer triagebot#1805
• Feature request: support manual r? without automatic reviewer assignment triagebot#1806

[RalfJung]

For now apparently we can use @rustbot assign $name instead of r? and that should work in PRs as well.