Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup #1998

Merged
merged 1 commit into from
Mar 5, 2022
Merged

rustup #1998

merged 1 commit into from
Mar 5, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 5, 2022

Adjusts our tests for rust-lang/rust#92697

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2022

📌 Commit 72e6d41 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Mar 5, 2022

⌛ Testing commit 72e6d41 with merge fcc2dd0...

bors added a commit that referenced this pull request Mar 5, 2022
@bors
Auto merge of #1998 - RalfJung:rustup, r=RalfJung
fcc2dd0 
rustup

Adjusts our tests for rust-lang/rust#92697
@bors
Copy link
Contributor

bors commented Mar 5, 2022

💔 Test failed - checks-actions

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2022

Ah, cargo miri test no longer works with isolation at all now... that's not good. I think I'll try to adjust the stdlib instead.

Or maybe it is time to switch the default to -Zmiri-isolation-error=hide (i.e., just return an error code from open)?

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2022

Cc rust-lang/rust#94645

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2022

📌 Commit ec0e513 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Mar 5, 2022

⌛ Testing commit ec0e513 with merge 2c1b9ce...

@bors
Copy link
Contributor

bors commented Mar 5, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2c1b9ce to master...

@bors bors merged commit 2c1b9ce into rust-lang:master Mar 5, 2022
@RalfJung RalfJung deleted the rustup branch March 5, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @bors