Try to ensure measureme output is valid when the interpreter is interrupted #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
May 21, 2023
src/concurrency/thread.rs
Outdated
| // immediately. In our interpreter loop we try to consult this value often, but if for | ||
| // whatever reason we don't get to that check or the cleanup we do upon finding that | ||
| // this bool has become true takes a long time, the exit here will promptly exit the | ||
| // process. |
There was a problem hiding this comment.
Suggested change
| // process. | |
| // process on the 2nd Ctrl-C. |
That's assuming I understood the code correctly
RalfJung
reviewed
May 21, 2023
RalfJung
reviewed
May 21, 2023
|
|
||
| /// Called when the interpreter is going to shut down abnormally, such as due to a ctrl+c. | ||
| pub(crate) fn handle_abnormal_termination(&mut self) { | ||
| drop(self.profiler.take()); |
There was a problem hiding this comment.
Would be good to have a comment explaining why this is important.
|
r=me after squashing |
saethlin
force-pushed
the
measureme-cleanup
branch
from
76acfcc to
e0080bf
Compare
|
@bors r=RalfJung |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping our
measureme::Profilerwill have the profiler flush its output buffer and write out its string table. If the profiler'sDropimpl does not run, the output file is not usable.This approach has zero runtime overhead.